lew/pda
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(del): support for multi deletion

Browse source
This commit is contained in:
Lewis Wynne 2025-12-17 18:18:48 +00:00
parent 52684d9e38
commit 14897ba587
6 changed files with 66 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

11
README.md
View file

@ -123,14 +123,21 @@ pda mv name name2 --copy
<p align="center"></p><!-- spacer -->
`pda del` to delete a key.
`pda del` to delete one or more keys.
```bash
pda del kitty
# Are you sure you want to delete kitty? [y/N]
# remove "kitty": are you sure? [y/n]
# y
pda del kitty dog@animals
# remove "kitty", "dog@animals": are you sure? [y/n]
# y
# Or skip the prompt.
pda del kitty --force
# Delete many in one go.
pda del kitty dogs cats --force
```
<p align="center"></p><!-- spacer -->

40
cmd/del.go
View file

@ -32,10 +32,10 @@ import (
// delCmd represents the set command
var delCmd = &cobra.Command{
Use: "del KEY[@DB]",
Short: "Delete a key. Optionally specify a db.",
Use: "del KEY[@DB] [KEY[@DB] ...]",
Short: "Delete one or more keys. Optionally specify a db.",
Aliases: []string{"delete", "rm", "remove"},
Args: cobra.ExactArgs(1),
Args: cobra.MinimumNArgs(1),
RunE: del,
SilenceUsage: true,
}
@ -48,22 +48,29 @@ func del(cmd *cobra.Command, args []string) error {
return err
}
exists, err := keyExists(store, args[0])
targetKeys := make([]string, 0, len(args))
for _, arg := range args {
exists, err := keyExists(store, arg)
if err != nil {
return fmt.Errorf("cannot remove '%s': %v", args[0], err)
return fmt.Errorf("cannot remove '%s': %v", arg, err)
}
if !exists {
return fmt.Errorf("cannot remove '%s': No such key", args[0])
return fmt.Errorf("cannot remove '%s': No such key", arg)
}
targetKey, err := formatKeyForPrompt(store, args[0])
targetKey, err := formatKeyForPrompt(store, arg)
if err != nil {
return err
}
targetKeys = append(targetKeys, targetKey)
}
if !force {
var confirm string
message := fmt.Sprintf("remove %q: are you sure? (y/n)", targetKey)
quotedTargets := make([]string, 0, len(targetKeys))
for _, t := range targetKeys {
quotedTargets = append(quotedTargets, fmt.Sprintf("%q", t))
}
message := fmt.Sprintf("remove %s: are you sure? (y/n)", strings.Join(quotedTargets, ", "))
fmt.Println(message)
if _, err := fmt.Scanln(&confirm); err != nil {
return fmt.Errorf("cannot remove '%s': %v", args[0], err)
@ -73,22 +80,29 @@ func del(cmd *cobra.Command, args []string) error {
}
}
for _, arg := range args {
arg := arg
trans := TransactionArgs{
key: args[0],
key: arg,
readonly: false,
sync: false,
transact: func(tx *badger.Txn, k []byte) error {
if err := tx.Delete(k); errors.Is(err, badger.ErrKeyNotFound) {
return fmt.Errorf("cannot remove '%s': No such key", args[0])
return fmt.Errorf("cannot remove '%s': No such key", arg)
}
if err != nil {
return fmt.Errorf("cannot remove '%s': %v", args[0], err)
return fmt.Errorf("cannot remove '%s': %v", arg, err)
}
return nil
},
}
return store.Transaction(trans)
if err := store.Transaction(trans); err != nil {
return err
}
}
return nil
}
func init() {

7
testdata/del__multiple__ok.ct vendored Normal file
View file

@ -0,0 +1,7 @@
$ pda set a 1
$ pda set b 2
$ pda del a b --force
$ pda get a --> FAIL
Error: cannot get 'a': Key not found
$ pda get b --> FAIL
Error: cannot get 'b': Key not found

8
testdata/help__del__ok.ct vendored
View file

@ -1,9 +1,9 @@
$ pda help del
$ pda del --help
Delete a key. Optionally specify a db.
Delete one or more keys. Optionally specify a db.
Usage:
pda del KEY[@DB] [flags]
pda del KEY[@DB] [KEY[@DB] ...] [flags]
Aliases:
del, delete, rm, remove
@ -11,10 +11,10 @@ Aliases:
Flags:
-f, --force Force delete without confirmation
-h, --help help for del
Delete a key. Optionally specify a db.
Delete one or more keys. Optionally specify a db.
Usage:
pda del KEY[@DB] [flags]
pda del KEY[@DB] [KEY[@DB] ...] [flags]
Aliases:
del, delete, rm, remove

4
testdata/help__ok.ct vendored
View file

@ -15,7 +15,7 @@ Usage:
Available Commands:
completion Generate the autocompletion script for the specified shell
cp Make a copy of a key.
del Delete a key. Optionally specify a db.
del Delete one or more keys. Optionally specify a db.
del-db Delete a database.
dump Dump all key/value pairs as NDJSON
get Get a value for a key. Optionally specify a db.
@ -46,7 +46,7 @@ Usage:
Available Commands:
completion Generate the autocompletion script for the specified shell
cp Make a copy of a key.
del Delete a key. Optionally specify a db.
del Delete one or more keys. Optionally specify a db.
del-db Delete a database.
dump Dump all key/value pairs as NDJSON
get Get a value for a key. Optionally specify a db.

2
testdata/root__ok.ct vendored
View file

@ -14,7 +14,7 @@ Usage:
Available Commands:
completion Generate the autocompletion script for the specified shell
cp Make a copy of a key.
del Delete a key. Optionally specify a db.
del Delete one or more keys. Optionally specify a db.
del-db Delete a database.
dump Dump all key/value pairs as NDJSON
get Get a value for a key. Optionally specify a db.