lew/guestbook
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: alt-text on submitted drawings

Browse source
This commit is contained in:
Lewis Wynne 2026-04-10 15:34:23 +01:00
parent a06f380b67
commit a1ddbba660
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/render.rs
View file

@ -280,8 +280,9 @@ fn render_entry(entry: &Entry, config: &Config) -> String {
}; };
let drawing_html = if !entry.meta.drawing.is_empty() { let drawing_html = if !entry.meta.drawing.is_empty() {
format!( format!(
"<img class=\"entry-drawing\" src=\"/drawings/{}\">", "<img class=\"entry-drawing\" src=\"/drawings/{}\" alt=\"Drawing by {}\">",
escape_html(&entry.meta.drawing) escape_html(&entry.meta.drawing),
escape_html(&entry.meta.name)
) )
} else { } else {
String::new() String::new()
@ -545,7 +546,7 @@ mod tests {
entry.meta.drawing = "2026-04-09-abc123.png".into(); entry.meta.drawing = "2026-04-09-abc123.png".into();
let form = render_form(&config); let form = render_form(&config);
let html = render_page(DEFAULT_TEMPLATE, &config, &[entry], &form); let html = render_page(DEFAULT_TEMPLATE, &config, &[entry], &form);
assert!(html.contains(r#"<img class="entry-drawing" src="/drawings/2026-04-09-abc123.png">"#)); assert!(html.contains(r#"<img class="entry-drawing" src="/drawings/2026-04-09-abc123.png" alt="Drawing by alice">"#));
} }
#[test] #[test]
@ -557,7 +558,7 @@ mod tests {
let form = render_form(&config); let form = render_form(&config);
let html = render_page(DEFAULT_TEMPLATE, &config, &[entry], &form); let html = render_page(DEFAULT_TEMPLATE, &config, &[entry], &form);
// Drawing renders regardless // Drawing renders regardless
assert!(html.contains(r#"<img class="entry-drawing" src="/drawings/2026-04-09-abc123.png">"#)); assert!(html.contains(r#"<img class="entry-drawing" src="/drawings/2026-04-09-abc123.png" alt="Drawing by alice">"#));
// But body HTML is escaped // But body HTML is escaped
assert!(html.contains("&lt;script&gt;")); assert!(html.contains("&lt;script&gt;"));
} }